so-rose/oscillode
1
0
Fork 0
Code Issues 50 Pull requests Projects Releases Packages Wiki Activity

Tidy3DWebRunnerNode doesn't require the visibility of a cost estimate before running a simulation #41

New issue
Open
opened 2024-05-05 09:28:50 +02:00 by so-rose · 0 comments
so-rose commented 2024-05-05 09:28:50 +02:00
Owner
Copy link

It's critical that the user be guaranteed informed about how much running a particular simulation will cost. Therefore, is_task_runnable should also check that estimated cost.

It's not done so far, because caching of estimated cost isn't something currently done in tdcloud.CloudTaskInfo (it's currently just a callable). We could look into a @cached_property, since in most cases, Tidy3DWebExporterNode will perform the expensive cost estimation, and hand that object off directly - causing the instance to reuse the estimated cost value.

It's critical that the user be guaranteed informed about how much running a particular simulation will cost. Therefore, `is_task_runnable` should also check that estimated cost. It's not done so far, because caching of estimated cost isn't something currently done in `tdcloud.CloudTaskInfo` (it's currently just a callable). We could look into a `@cached_property`, since in most cases, `Tidy3DWebExporterNode` will perform the expensive cost estimation, and hand that object off directly - causing the instance to reuse the estimated cost value.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
uv-refactor
No results found.
Labels
Clear labels   
abstractions

Related to the functionality of the abstractions used to make node/socket design tolerable.

  
architecture

Related to the internal approach / structuring of functionality.

  
bug

Something that isn't working.

  
distribution

Related to processes that gets the software into the hands of users.

  
docs

Related to the documentation, both reference and user-facing.

  
duplicate

An issue that already exists.

  
enhancement

Something to improve existing functionality.

  
feature

A feature to implement ex. node, socket, etc. .

  
physical

Related to the physical correctness or modelling of the tool.

  
proposal

A proposal for a large/radical feature or change, to explain the why/how/status.

  
question

A question for a more qualified person.

  
simulation

A particular simulation-based test, benchmark, or project of real-world significance.

  
tooling

Related to the developer tooling that keeps the developer's mind sane and happy.

  
tracker

Aggregating tracker for other Issues.

  
unconfirmed

Don't know exactly what's going on yet - ideal for ex. user reports.

  
ux

Related to the user experience, visual communication, etc. .

  
wontfix

Something that doesn't work that won't be fixed, on purpose.

No labels
abstractions
architecture
bug
distribution
docs
duplicate
enhancement
feature
physical
proposal
question
simulation
tooling
tracker
unconfirmed
ux
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: so-rose/oscillode#41
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?