ArrayFlow.rescale_to_unit incorrectly presumes that sorted-state is always preserved #40

Open
opened 2024-05-05 09:25:43 +02:00 by so-rose · 0 comments

In this case, scaling to a unit will generally preserve sorting, but if it were to not, some very nasty bugs will jump out. Whether the array is sorted is essential, since it allows the use of a fast binary search algorithm to find indices corresponding to values (one which must run every time a fixed coordinate is altered in the FilterNode).

We can do checks to correctly propagate ArrayFlow.is_sorted, and we should.

In this case, scaling to a unit will **generally** preserve sorting, but if it were to not, some very nasty bugs will jump out. Whether the array is sorted is essential, since it allows the use of a fast binary search algorithm to find indices corresponding to values (one which must run every time a fixed coordinate is altered in the `FilterNode`). We can do checks to correctly propagate `ArrayFlow.is_sorted`, and we should.
so-rose added the
bug
label 2024-05-05 09:25:43 +02:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: so-rose/oscillode#40
There is no content yet.