Altering temporal shape node parameters causes E(t) to recompile per-change #39

Closed
opened 2024-05-05 09:22:12 +02:00 by so-rose · 1 comment

In particular, the use of partial() in compute_time_to_efield_lazy causes a recompile, breaking the JIT chain.

All these parameters should be manually passed in the ParamsFlow, which requires a restructuring of manual_amp_time to accept all the parameters from self instead of just passing the tidy3d temporal shape. It's not a ton of work, but it's not nothing, and it would fix the recompilation-per-change that can cause an unfortunate amount of lag.

In particular, the use of `partial()` in `compute_time_to_efield_lazy` causes a recompile, breaking the JIT chain. All these parameters should be manually passed in the `ParamsFlow`, which requires a restructuring of `manual_amp_time` to accept all the parameters from `self` instead of just passing the `tidy3d` temporal shape. It's not a ton of work, but it's not nothing, and it would fix the recompilation-per-change that can cause an unfortunate amount of lag.
so-rose added the
bug
label 2024-05-05 09:22:12 +02:00
Poster
Owner

We simply removed it for now. It was more of an easter egg than actually useful in its current state.

We simply removed it for now. It was more of an easter egg than actually useful in its current state.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: so-rose/oscillode#39
There is no content yet.