Altering temporal shape node parameters causes `E(t)` to recompile per-change #39

New issue

Closed

opened 2024-05-05 09:22:12 +02:00 by so-rose · 1 comment

so-rose commented

2024-05-05 09:22:12 +02:00

Owner

In particular, the use of partial() in compute_time_to_efield_lazy causes a recompile, breaking the JIT chain.

All these parameters should be manually passed in the ParamsFlow, which requires a restructuring of manual_amp_time to accept all the parameters from self instead of just passing the tidy3d temporal shape. It's not a ton of work, but it's not nothing, and it would fix the recompilation-per-change that can cause an unfortunate amount of lag.

In particular, the use of `partial()` in `compute_time_to_efield_lazy` causes a recompile, breaking the JIT chain. All these parameters should be manually passed in the `ParamsFlow`, which requires a restructuring of `manual_amp_time` to accept all the parameters from `self` instead of just passing the `tidy3d` temporal shape. It's not a ton of work, but it's not nothing, and it would fix the recompilation-per-change that can cause an unfortunate amount of lag.